mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63368: Added MemoryProfiler class to Libprocess.
Date Fri, 10 Nov 2017 16:31:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63368/#review190728
-----------------------------------------------------------




3rdparty/libprocess/include/process/memory_profiler.hpp
Lines 22 (patched)
<https://reviews.apache.org/r/63368/#comment268331>

    System headers first please



3rdparty/libprocess/src/memory_profiler.cpp
Lines 44-52 (patched)
<https://reviews.apache.org/r/63368/#comment268334>

    My gut feeling is that this will not fly on Windows. Is the plan to exclude this file
from compilation with msvc?



3rdparty/libprocess/src/memory_profiler.cpp
Lines 287-296 (patched)
<https://reviews.apache.org/r/63368/#comment268335>

    Looks like these guys did not make it into MVP.



3rdparty/libprocess/src/memory_profiler.cpp
Lines 516-519 (patched)
<https://reviews.apache.org/r/63368/#comment268336>

    I remember there was something about caching in hpp...?



3rdparty/libprocess/src/memory_profiler.cpp
Lines 527 (patched)
<https://reviews.apache.org/r/63368/#comment268337>

    Are we aure `jeprof` is available? Or we don't care?



3rdparty/libprocess/src/memory_profiler.cpp
Lines 531 (patched)
<https://reviews.apache.org/r/63368/#comment268338>

    Also "if.isElse" : ). Let's s/success/schell/


- Alexander Rukletsov


On Oct. 27, 2017, 7:04 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63368/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 7:04 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This class exposes profiling functionality of jemalloc memory allocator
> when it is detected to be the memory allocator of the current process.
> 
> In particular, it gives developers an easy method to collect and
> access heap profiles which report which pieces of code were
> responsible for allocating memory.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 03a0ca87f31744c716c99e05aa07242fed480675 
>   3rdparty/libprocess/include/process/memory_profiler.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/process.hpp dc3375ce62556322eb2bc60ade61f313ade123b8

>   3rdparty/libprocess/src/memory_profiler.cpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 71ae7129ffbd0e22eda2863b17bbcf588298c37b 
> 
> 
> Diff: https://reviews.apache.org/r/63368/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message