mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 63694: Added context to agent processing calls.
Date Fri, 10 Nov 2017 11:23:09 GMT


> On Nov. 9, 2017, 5:26 p.m., Alexander Rukletsov wrote:
> > src/slave/http.cpp
> > Line 2750 (original), 2793 (patched)
> > <https://reviews.apache.org/r/63694/diff/2/?file=1885741#file1885741line2793>
> >
> >     This check is actually weird. {{ContainerID}} is optional in {{AttachContainerInput}}
protobuf. Could you please contact the author and check whether we should make the field required
or remove the check? Or maybe there is some validation before?

Well, it is rather simple, the first message needs to be of type `CONTAINER_ID` and have a
`container_id`.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63694/#review190601
-----------------------------------------------------------


On Nov. 9, 2017, 10:50 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63694/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 10:50 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7361
>     https://issues.apache.org/jira/browse/MESOS-7361
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds information such as the container ID when processing calls
> regarding nested containers, the level when setting a new logging
> level, and the path when processing calls regarding files.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp cfae9979e58bca1864551bf16b741d6bae6602f8 
> 
> 
> Diff: https://reviews.apache.org/r/63694/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message