mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 63710: Fixed flaky RescindRevocableOfferWithIncreasedRevocable test.
Date Thu, 09 Nov 2017 23:45:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63710/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-7519
    https://issues.apache.org/jira/browse/MESOS-7519


Repository: mesos


Description
-------

This is addendum to review https://reviews.apache.org/r/55893/.
The loop that merges outstanding offers can miss some because it
removes the items from the collection it iterates over.


Diffs
-----

  src/tests/oversubscription_tests.cpp d262bbe06787f70427f4f7820e64891c7d1b5552 


Diff: https://reviews.apache.org/r/63710/diff/1/


Testing
-------

`GLOG_v=2 GTEST_FILTER="*RescindRevocableOfferWithIncreasedRevocable*" ./bin/mesos-tests.sh
--verbose --gtest_repeat=1000 --gtest_break_on_failure` on Mac OS 10.11.6
does not fail with the patch while consistently fails without.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message