mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 62214: Added JavaScript linter.
Date Thu, 09 Nov 2017 15:53:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review190597
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Oct. 18, 2017, 9:23 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 9:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
>     https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -----
> 
>   support/.eslintrc.js PRE-CREATION 
>   support/build-virtualenv b46a86a2604925f936bbb9d3414d5be3976836db 
>   support/mesos-style.py 96030f21c08d893d49471ff73f50d185afcd16d6 
>   support/pip-requirements.txt 6ae67d005e85a1334701e8f644e9c32dfd5f20a5 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/9/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript file and
checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message