mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 62214: Added JavaScript linter.
Date Thu, 09 Nov 2017 15:26:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review190595
-----------------------------------------------------------




support/mesos-style.py
Lines 107 (patched)
<https://reviews.apache.org/r/62214/#comment268082>

    I seem to be getting this error when testing manually:
    ```
    Checking 1 JavaScript file
    Traceback (most recent call last):
      File "support/mesos-style.py", line 472, in <module>
        JS_ERRORS = JS_LINTER.main(sys.argv[1:])
      File "support/mesos-style.py", line 344, in main
        return super(JsLinter, self).main(modified_files)
      File "support/mesos-style.py", line 210, in main
        lint_errors = self.run_lint(list(filtered_candidates_set))
      File "support/mesos-style.py", line 332, in run_lint
        config=config_path)
      File "support/mesos-style.py", line 108, in run_command_in_virtualenv
        shell=True, stdout=subprocess.PIPE)
      File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 710, in __init__
        errread, errwrite)
      File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 1335, in _execute_child
        raise child_exception
    TypeError: execv() arg 2 must contain only strings
    ```


- Kevin Klues


On Oct. 18, 2017, 9:23 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 9:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
>     https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -----
> 
>   support/.eslintrc.js PRE-CREATION 
>   support/build-virtualenv PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
>   support/pip-requirements.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/8/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript file and
checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message