mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <>
Subject Re: Review Request 63662: Dropped scheduler call if a connection has been interrupted.
Date Thu, 09 Nov 2017 10:00:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 9, 2017, 10 a.m.)

Review request for mesos, Greg Mann and Till Toenshoff.

Bugs: MESOS-8179

Repository: mesos

Description (updated)

Prior to this patch, if a connection to the master is interrupted
between `send()` and `_send()`, scheduler library will crash on
`CHECK`. Since the connection can turn into pumpkin at any time, we
should not fail in this case.


  src/scheduler/scheduler.cpp fe374541621015d04a594f68d009ce50ec751d30 



make check on Mac OS 10.11.6

Additionally run
GLOG_v=1 GTEST_FILTER="*SchedulerTest.MasterFailover*" ./bin/ --verbose --gtest_repeat=100
and grepped for "Connection to master" to ensure that this path is taken. `SchedulerTest.MasterFailover`
is modified locally to increase chances by adding multiple `detector->appoint(master.get()->pid);`


Alexander Rukletsov

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message