mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.
Date Thu, 09 Nov 2017 09:08:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63689/#review190556
-----------------------------------------------------------




src/master/master.cpp
Lines 10966-10971 (patched)
<https://reviews.apache.org/r/63689/#comment268035>

    `Master::_apply` will currently always call `Slave::apply`. This means that the changes
above (calling `Master::_apply` for storage operation) will always trigger these cases. `Slave::apply`
should ignore these operations instead of failing over. Or we move the switch to `Master::_apply`
so that `Slave::apply` is only called for `RESERVE`, `UNRESERVE`, `CREATE`, `DESTROY`.


- Jan Schlicht


On Nov. 9, 2017, 1:02 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63689/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-7235
>     https://issues.apache.org/jira/browse/MESOS-7235
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `Master::_apply` consistently for all offer operations.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp e1381a9a4f0183548a2b8ea8431bf52b0739629f 
> 
> 
> Diff: https://reviews.apache.org/r/63689/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message