mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.
Date Thu, 09 Nov 2017 09:04:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63680/#review190555
-----------------------------------------------------------



Bad patch!

Reviews applied: [63680, 63019, 63385, 63060, 63377, 63018, 62637, 62636, 62762, 62635, 62633,
63376, 63058, 63057, 63056, 63054, 62145, 62144, 62143, 62142, 60891, 60890, 60889, 60888,
61806, 61805]

Failed command: python support/apply-reviews.py -n -r 62145

Error:
2017-11-09 09:04:15 URL:https://reviews.apache.org/r/62145/diff/raw/ [28804/28804] -> "62145.patch"
[1]
error: patch failed: src/slave/http.cpp:2345
error: src/slave/http.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/20038/console

- Mesos Reviewbot


On Nov. 9, 2017, 3:55 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63680/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 3:55 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-8183
>     https://issues.apache.org/jira/browse/MESOS-8183
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ContanierDaemon` class is responsible to monitor if a long-running
> service running in a standalone container is ready to serve, and restart
> the service container if not. It takes the following 3 hook functions:
> 
> * `preStartHook`: called prior to container launch.
> * `readinessHook`: called periodically to check if the service is ready.
>   If a duration is returned, it serves as a backoff period, meaning that
>   the next check will be scheduled after the duration. It can also be
>   used to set up futures to reflect the readiness of the status outside
>   the container daemon.
> * `postStopHook`: called after the container is killed.
> 
> `ContainerDaemon` does not manage the lifecycle of the contanier it
> monitors, so the container persists across `ContainerDaemon`s. However,
> it provides a `terminate()` method to completely shutdown the monitoring
> container.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
>   src/slave/container_daemon.hpp PRE-CREATION 
>   src/slave/container_daemon.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63680/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message