mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
Date Thu, 09 Nov 2017 01:10:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review190523
-----------------------------------------------------------




src/Makefile.am
Lines 2469 (patched)
<https://reviews.apache.org/r/62579/#comment267973>

    This is linux specific. Should be under OS_LINUX, right?



src/tests/CMakeLists.txt
Lines 186 (patched)
<https://reviews.apache.org/r/62579/#comment267974>

    ditto.
    
    after second thought, let's move the test to cgroups_isolator_tests.cpp for now.



src/tests/containerizer/blkio_isolator_tests.cpp
Lines 51 (patched)
<https://reviews.apache.org/r/62579/#comment267976>

    if we move to `cgroups_isolator_tests.cpp`, let's use `ROOT_CGROUPS_` prefix.


- Gilbert Song


On Oct. 19, 2017, 5:29 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 5:29 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 936bc49ddfca03b9278ab11b6d317f3ff635cb00 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message