mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.
Date Thu, 09 Nov 2017 00:43:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63680/#review190518
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 62145.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62145`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63680

Relevant logs:

- [apply-review-62145-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63680/logs/apply-review-62145-stdout.log):

```
error: patch failed: src/slave/http.cpp:2345
error: src/slave/http.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 8, 2017, 11:55 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63680/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 11:55 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-8183
>     https://issues.apache.org/jira/browse/MESOS-8183
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ContanierDaemon` class is responsible to monitor if a long-running
> service running in a standalone container is ready to serve, and restart
> the service container if not. It takes the following 3 hook functions:
> 
> * `preStartHook`: called prior to container launch.
> * `readinessHook`: called periodically to check if the service is ready.
>   If a duration is returned, it serves as a backoff period, meaning that
>   the next check will be scheduled after the duration. It can also be
>   used to set up futures to reflect the readiness of the status outside
>   the container daemon.
> * `postStopHook`: called after the container is killed.
> 
> `ContainerDaemon` does not manage the lifecycle of the contanier it
> monitors, so the container persists across `ContainerDaemon`s. However,
> it provides a `terminate()` method to completely shutdown the monitoring
> container.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
>   src/slave/container_daemon.hpp PRE-CREATION 
>   src/slave/container_daemon.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63680/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message