mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.
Date Wed, 08 Nov 2017 23:28:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63276/#review190505
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/windows.hpp
Lines 47 (patched)
<https://reviews.apache.org/r/63276/#comment267935>

    Can you move the implementation to a cpp file (instead of putting in the header)?



src/slave/containerizer/mesos/isolators/windows.hpp
Lines 74-82 (patched)
<https://reviews.apache.org/r/63276/#comment267936>

    That's the default implementation in MesosIsolatorProcess. Simply remove this method?



src/slave/containerizer/mesos/isolators/windows.hpp
Lines 35-41 (original), 100-109 (patched)
<https://reviews.apache.org/r/63276/#comment267937>

    Remove this given this is the default behavor in parent class?



src/slave/containerizer/mesos/isolators/windows.hpp
Line 60 (original), 153 (patched)
<https://reviews.apache.org/r/63276/#comment267943>

    I think we should call `update` in `isolate` too. Otherwise, the process won't be subject
to cpu/mem limitation until the next `update` is called.
    
    I you think inheritence is hard, maybe just get rid the base class. a little bit code
duplication is not too bad and will make it much easier to read.



src/slave/containerizer/mesos/isolators/windows.hpp
Line 64 (original), 210 (patched)
<https://reviews.apache.org/r/63276/#comment267941>

    2 lines apart.


- Jie Yu


On Nov. 6, 2017, 11:18 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63276/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2017, 11:18 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich,
Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-5462 and MESOS-6690
>     https://issues.apache.org/jira/browse/MESOS-5462
>     https://issues.apache.org/jira/browse/MESOS-6690
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of deriving from the POSIX isolators, we now have two real
> Windows isolators that can be used together or separately. The `Cpu`
> isolator enables a hard-cap CPU limit, and the `Mem` isolator enables a
> hard-cap memory limit on the job object for the container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 100e3bbda543d87808da9ff6bea42da5099ea8c5

>   src/slave/containerizer/mesos/isolators/windows.hpp b0621a5fc411b8812722f7fcf6580ed64dac5382

>   src/slave/flags.cpp 63aaac218fdc067742d39f1fc8497723784d9595 
> 
> 
> Diff: https://reviews.apache.org/r/63276/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message