-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63652/#review190499
-----------------------------------------------------------
PASS: Mesos patch 63652 was successfully built and tested.
Reviews applied: `['63652']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63652
- Mesos Reviewbot Windows
On Nov. 8, 2017, 6:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63652/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 6:46 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8121
> https://issues.apache.org/jira/browse/MESOS-8121
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In unified containerizer, the d_type cannot be 1
> if we are using the overlay fs backend.
> In particular, XFS can be mounted with ftype = 0
> which renders d_type == 0. Raise error if user
> specifies overlayfs as backend. Fallback to other
> backends in the default case and raise a warning.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/provisioner.cpp 450a3b32d69d2882973a6ed4e94e169a0256056b
> src/slave/containerizer/mesos/provisioner/utils.hpp 5b6c162fe4ade16131b2207d707e76228b0ec51a
> src/slave/containerizer/mesos/provisioner/utils.cpp 7fd7315dda99f49f967a665afe27c8db7835c04c
>
>
> Diff: https://reviews.apache.org/r/63652/diff/2/
>
>
> Testing
> -------
>
> Manually tested slave creation with default and overlayfs backends on XFS based work_dir
with different ftype mount options.
>
>
> Thanks,
>
> Meng Zhu
>
>
|