mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63620: Updated offer operation handling to set resource versions.
Date Wed, 08 Nov 2017 22:04:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63620/#review190496
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 5391 (patched)
<https://reviews.apache.org/r/63620/#comment267921>

    I would call this `resourceVersion` to be consistent with below.



src/master/master.cpp
Lines 5393-5400 (patched)
<https://reviews.apache.org/r/63620/#comment267920>

    I'd just use CHECK here (to be consistent with that in `_apply`)


- Jie Yu


On Nov. 8, 2017, 3:23 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63620/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 3:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Resource version UUIDs are used to establish a relationship between
> operation and the resource they are operating on. For each agent the
> master keeps track of its resource version and the resource version of
> the agents' resource providers. As resource versions are required in a
> 'ApplyOfferOperationMessage', the master has to find the resource
> version that's matching the resources an operation should apply to and
> set it accordingly.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ee212c1a21b432d3aa8e90d748d12cb0a754d57c 
> 
> 
> Diff: https://reviews.apache.org/r/63620/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message