mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 63674: Updated a comment about resubscribing completed frameworks.
Date Wed, 08 Nov 2017 19:43:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63674/#review190486
-----------------------------------------------------------


Fix it, then Ship it!




LGTM modulo Gaston's suggestion.


src/master/master.cpp
Line 2671 (original), 2671 (patched)
<https://reviews.apache.org/r/63674/#comment267868>

    While you are at it you can remove the bit about the driver since this function only applies
to the HTTP based frameworks.


- Anand Mazumdar


On Nov. 8, 2017, 5:31 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63674/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 5:31 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 01675ed53aa115f35e5bcee534e4625b35f1889e 
> 
> 
> Diff: https://reviews.apache.org/r/63674/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in repetition on Mac OS 10.11.6
> 
> `GTEST_FILTER="*SchedulerTest.MasterFailover*" ./bin/mesos-tests.sh --verbose --gtest_repeat=500
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message