mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63515: Updated xfs/disk, gpu, and cgroups isolators' prepare function.
Date Wed, 08 Nov 2017 19:30:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63515/#review190484
-----------------------------------------------------------



Can you update `network/port_mapping` isolator as well. There is a use of executor_info as
well.

- Jie Yu


On Nov. 2, 2017, 4:04 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63515/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 4:04 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These three isolators refered to the ExecutorInfo field of the given
> ContainerConfig to determine the total resources to isolate.  This
> changes these isolators to refer instead to the Resources field of the
> given ContainerConfig because the resource amounts should be identical
> (enforced by the caller to Containerizer::launch, such as the agent)
> and in order to support standalone containers, which specify resources
> but no ExecutorInfo.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 549a4551736d1b88a79f275a2d6e19c586c49f26

>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 25636b50314cb4ea53d1931c97c87c65ecb658a8

>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 2113f8665e4e84bdf12868f605b480522816a9ba

> 
> 
> Diff: https://reviews.apache.org/r/63515/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> sudo src/mesos-tests
> 
> On... 
> OSX and Ubuntu 16
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message