mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63514: Updated tests with Containerizer::launch interface change.
Date Wed, 08 Nov 2017 19:25:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63514/#review190482
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Nov. 2, 2017, 4:04 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63514/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 4:04 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit contains the test changes required due to the interface
> change in https://reviews.apache.org/r/63063 .
> 
> Instead of `AWAIT_ASSERT_TRUE(...)`, the affected test lines now use
> `AWAIT_ASSERT_EQ(Containerizer::LaunchResult::SUCCESS, ...)`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp a778b8581904bacea9eec3ff50c3c009959b5dac 
>   src/tests/containerizer.cpp cd140f4263621a0a33a34b7e062a9ca6cf426e7a 
>   src/tests/containerizer/composing_containerizer_tests.cpp 61e47e9cffb565e4621babb28e9bf8736945c386

>   src/tests/containerizer/io_switchboard_tests.cpp c3410cdbb21b974455d443a18e4af09eddea59ca

>   src/tests/containerizer/isolator_tests.cpp 4ad42bc427acebc7fe7e4d8d0d346537db23c9b1

>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 4dfd90bee600f3b91183c60a0216d3990f0fba10

>   src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee

>   src/tests/containerizer/mock_containerizer.hpp 0adcb01e6c12d6cc4abed1f14fa2df833ffc6569

>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp fbd2887800ccfd64c8628c5d6fd77a511c8f91d5

>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 1d006727e5bf76cc659e862cb64fe3facd608c8c

>   src/tests/containerizer/volume_image_isolator_tests.cpp 2f91730075c0eca455be84bc1f1b01b4395fb382

>   src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp b36c8df4df346096ed3f0ca3411b3ab5d9a8c74e

>   src/tests/containerizer/volume_secret_isolator_tests.cpp a55af954bdacfcc7b629fe6e5c47759dc0e8a709

>   src/tests/hook_tests.cpp 542878210d0d335f504220ac21284a3239f419ee 
>   src/tests/mock_docker.hpp 59873646be494c8fe6aebf5ede595d77e3ac4cae 
>   src/tests/slave_recovery_tests.cpp db337ba4e213820e7ad0c3f1b480388a2e456556 
>   src/tests/slave_tests.cpp aae5e6021b46793fa2b871aaa738f61c8cfb88ce 
> 
> 
> Diff: https://reviews.apache.org/r/63514/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> On... 
> OSX and Ubuntu 16
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message