> On Nov. 8, 2017, 1:48 p.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/os/posix/socket.hpp
> > Lines 89 (patched)
> > <https://reviews.apache.org/r/63654/diff/1/?file=1884313#file1884313line89>
> >
> > Does it make sense to return a `Try<array<int_fd, 2>>` here for
consistency with `os::pipe`?
>
> James Peach wrote:
> Yes.
Maybe we should switch `os::pipe` to this return convention? The amount of code that does
```
Try<std::array<int_fd, 2>> pipes_ = os::pipe();
const std::array<int_fd, 2>& pipes = pipes_.get();
```
suggests that the `os::pipe` API is not very convenient
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63654/#review190444
-----------------------------------------------------------
On Nov. 8, 2017, 1:12 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63654/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 1:12 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8156
> https://issues.apache.org/jira/browse/MESOS-8156
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `net::socketpair` helper to stout that deals with
> automatically setting O_CLOEXEC and disabling SIGPIPE where
> necessary.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/socket.hpp bab0b808f53abd1314a7d13fc0cba75e5717f96f
> 3rdparty/stout/tests/os/sendfile_tests.cpp 05966ae067ae3972598da3370eb16fdce5736c21
>
>
> Diff: https://reviews.apache.org/r/63654/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26, macOS)
>
>
> Thanks,
>
> James Peach
>
>
|