mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 63622: Provided handling for offer operation updates.
Date Wed, 08 Nov 2017 16:17:01 GMT


> On Nov. 7, 2017, 4:49 p.m., Benjamin Bannier wrote:
> > src/resource_provider/message.hpp
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/63622/diff/1/?file=1883859#file1883859line51>
> >
> >     Since we seem to mirror `Call.UpdateOfferOperationStatus` pretty closely here,
let's use an `Option<OfferOperationStatus> latestStatus`.

Fixed by using `OfferOperationStatusUpdate` instead.


> On Nov. 7, 2017, 4:49 p.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 319 (patched)
> > <https://reviews.apache.org/r/63622/diff/1/?file=1883862#file1883862line319>
> >
> >     I believe we could we could use a `MockResourceProvider` here to simplify the
test a bit.

This won't simplify a lot. But it could remove some duplicate code here and in `ResourceProviderManagerHttpApiTest.UpdateState`.
We should implement something in a follow-up ticket so that both test could benefit.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63622/#review190323
-----------------------------------------------------------


On Nov. 8, 2017, 5:12 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63622/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 5:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a resource provider has finished an offer operation, it will send
> a status update to the resource provider manager and subsequently to an
> agent. The agent then updates its internal bookkeeping and forwards the
> status update to the master.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 95f57da820db676874302f1c3138a76c22a88593 
>   src/common/protobuf_utils.cpp 7a4b87becbe73f0fa97ebceee6b71ede8dce90dd 
>   src/resource_provider/manager.cpp a878507d71a09a415d8a4573cf2b33c26c985451 
>   src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 
>   src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
>   src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 
>   src/tests/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2

> 
> 
> Diff: https://reviews.apache.org/r/63622/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message