mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63661: Updated tests to use `createCallSubscribe`.
Date Wed, 08 Nov 2017 12:04:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63661/#review190441
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63661]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 8, 2017, 10:46 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63661/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 10:46 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8094
>     https://issues.apache.org/jira/browse/MESOS-8094
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated all the tests that send v1 API SUBSCRIBE calls to use the
> `createCallSubscribe` test helper.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp d3e812a2a6302035634d14995939aafb216970df 
>   src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 
>   src/tests/slave_authorization_tests.cpp 11fd0d4e35523eca23a9603ecef0c9d0b65dde38 
>   src/tests/slave_recovery_tests.cpp 64bba047c6eaee563126a8bd1c6fa048f18172e1 
>   src/tests/slave_tests.cpp f9c2e6b41bdbc54ee0d8d06a2a41c92b7a1156cc 
> 
> 
> Diff: https://reviews.apache.org/r/63661/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message