mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 63652: Added d_type check in containerizer backend validation.
Date Wed, 08 Nov 2017 03:38:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63652/#review190420
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['63652']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63652

Relevant logs:

- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63652/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(271): warning C4267: 'argument':
conversion from 'size_t' to 'unsigned int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(333): warning C4267: '=':
conversion from 'size_t' to 'unsigned int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(216): warning C4267: 'argument':
conversion from 'size_t' to 'unsigned int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242): warning C4267: 'argument':
conversion from 'size_t' to 'unsigned int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274): warning C4267: '=':
conversion from 'size_t' to 'unsigned int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2103): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\common\protobuf_utils.cpp)
[C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\files\files.cpp(703): warning C4267: 'argument': conversion from
'size_t' to 'off_t', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2103): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\master\master.cpp)
[C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master\master.cpp(6185): warning C4244: 'argument': conversion from
'const ::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master\master.cpp(6272): warning C4244: 'argument': conversion from
'const ::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master\master.cpp(6855): warning C4244: 'argument': conversion from
'const ::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master\master.cpp(8376): warning C4244: 'argument': conversion from
'const ::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master\master.cpp(10147): warning C4244: 'return': conversion from
'::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2103): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\master\quota_handler.cpp)
[C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2103): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\master\weights_handler.cpp)
[C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning C4267: 'return':
conversion from 'size_t' to 'int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\slave/containerizer/mesos/isolators/posix.hpp(55): warning C4244:
'argument': conversion from 'google::protobuf::uint64' to 'const pid_t', possible loss of
data [C:\DCOS\mesos\src\mesos.vcxproj]
  C:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(755): warning C4244:
'argument': conversion from 'google::protobuf::uint64' to 'pid_t', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]


"C:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) -> 
  C:\DCOS\mesos\mesos\src\slave\containerizer\mesos\provisioner\utils.cpp(29): fatal error
C1083: Cannot open include file: 'linux/fs.h': No such file or directory [C:\DCOS\mesos\src\mesos.vcxproj]

    137 Warning(s)
    1 Error(s)

Time Elapsed 00:23:06.67
```

- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63652/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_65635.dir\Debug\cmTC_65635.tlog\".

InitializeBuildStatus:

  Creating "cmTC_65635.dir\Debug\cmTC_65635.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_65635.dir\Debug\" /Fd"cmTC_65635.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_65635.dir\Debug\" /Fd"cmTC_65635.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_65635.exe" /INCREMENTAL
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib
uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'"
/manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_65635.pdb" /SUBSYSTEM:CONSOLE
/TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_65635.lib"
/MACHINE:X64  /machine:x64 cmTC_65635.dir\Debug\src.obj

  cmTC_65635.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_65635.exe

  cmTC_65635.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_65635.pdb (Full PDB)

FinalizeBuildStatus:

  Deleting file "cmTC_65635.dir\Debug\cmTC_65635.tlog\unsuccessfulbuild".

  Touching "cmTC_65635.dir\Debug\cmTC_65635.tlog\cmTC_65635.lastbuildstate".

Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_65635.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:01.84


Source file was:
int main() { return 0; }
```

- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63652/logs/mesos-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_1a912.dir\Debug\".

  Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_1a912.dir\Debug\cmTC_1a912.tlog\".

InitializeBuildStatus:

  Creating "cmTC_1a912.dir\Debug\cmTC_1a912.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_1a912.dir\Debug\" /Fd"cmTC_1a912.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_1a912.dir\Debug\" /Fd"cmTC_1a912.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1a912.vcxproj]

Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1a912.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1a912.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open
include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1a912.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:01.12



```

- Mesos Reviewbot Windows


On Nov. 7, 2017, 11:59 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63652/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 11:59 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8121
>     https://issues.apache.org/jira/browse/MESOS-8121
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In unified containerizer, the d_type cannot be 1
> if we are using the overlay fs backend.
> In particular, XFS can be mounted with ftype = 0
> which renders d_type == 0. Raise error if user
> specifies overlayfs as backend. Fallback to other
> backends in the default case and raise a warning.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 450a3b32d69d2882973a6ed4e94e169a0256056b

>   src/slave/containerizer/mesos/provisioner/utils.hpp 5b6c162fe4ade16131b2207d707e76228b0ec51a

>   src/slave/containerizer/mesos/provisioner/utils.cpp 7fd7315dda99f49f967a665afe27c8db7835c04c

> 
> 
> Diff: https://reviews.apache.org/r/63652/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested slave creation with default and overlayfs backends on XFS based work_dir
with different ftype mount options.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message