mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62143: Added validation for Standalone Container APIs.
Date Wed, 08 Nov 2017 00:11:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62143/#review190396
-----------------------------------------------------------




src/slave/validation.cpp
Lines 381 (patched)
<https://reviews.apache.org/r/62143/#comment267728>

    You may want to normalize the resources to `POST_RESERVATION_REFINEMENT` format and use
`isUnreserved` check below?



src/slave/validation.cpp
Lines 396-400 (patched)
<https://reviews.apache.org/r/62143/#comment267729>

    This can be `isUnreserved` if the resources are normalized to post refinement format.



src/slave/validation.cpp
Lines 407-408 (patched)
<https://reviews.apache.org/r/62143/#comment267730>

    You can use `Resources::isPersistentVolume`


- Jie Yu


On Oct. 16, 2017, 11:44 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62143/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 11:44 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Standalone Container APIs act much like the nested container APIs,
> except that ContainerIDs do not necessarily need to have a parent.
> 
> Additionally, the 'resources' field in the `LAUNCH_CONTAINER` API
> has some restrictions due to how these resources are not reported
> to the master.
> 
> 
> Diffs
> -----
> 
>   src/slave/validation.cpp a575d88dffd2714447d7780a7433506a6e8c085f 
> 
> 
> Diff: https://reviews.apache.org/r/62143/diff/3/
> 
> 
> Testing
> -------
> 
> See later in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message