mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.
Date Tue, 07 Nov 2017 23:58:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63175/#review190385
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp
Line 363 (original), 366 (patched)
<https://reviews.apache.org/r/63175/#comment267720>

    Update this to
    
    ```
    CHECK(frameworks.contains(frameworkId))
      << frameworkId;
    ```
    
    like you do in other places?



src/master/allocator/mesos/hierarchical.cpp
Line 390 (original), 395 (patched)
<https://reviews.apache.org/r/63175/#comment267721>

    Update this to
    
    ```
    CHECK(frameworks.contains(frameworkId))
      << frameworkId;
    ```
    
    like you do in other places?



src/master/allocator/mesos/hierarchical.cpp
Lines 399 (patched)
<https://reviews.apache.org/r/63175/#comment267716>

    Move this to line 411 where the rest of the framework state is reset.



src/master/allocator/mesos/hierarchical.cpp
Lines 2009 (patched)
<https://reviews.apache.org/r/63175/#comment267718>

    I think this needs an explanatory comment.


- James Peach


On Nov. 7, 2017, 9:34 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63175/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 9:34 p.m.)
> 
> 
> Review request for mesos, James Peach and Joseph Wu.
> 
> 
> Bugs: MESOS-8085
>     https://issues.apache.org/jira/browse/MESOS-8085
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Do not generate UnavailableResources for inactive frameworks.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp c2346054b2c98516f15ab8ce2dc798224ff4def4

>   src/master/allocator/mesos/hierarchical.cpp 5b6efe5faa3c3b10f1f714f582a155b368f8ccaf

> 
> 
> Diff: https://reviews.apache.org/r/63175/diff/1/
> 
> 
> Testing
> -------
> 
> make check.
> 
> I didn' write a new test as the externally observable behavior doesn't change.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message