mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63649: Introduced `.clang-tidy` configuration file.
Date Tue, 07 Nov 2017 22:06:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63649/#review190373
-----------------------------------------------------------


Fix it, then Ship it!





support/mesos-tidy/entrypoint.sh
Lines 26 (patched)
<https://reviews.apache.org/r/63649/#comment267706>

    Let's add a comment here that we require this so `.clang-tidy` is present at the project
root.


- Benjamin Bannier


On Nov. 7, 2017, 11:02 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63649/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 11:02 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   bootstrap d0dd491e99b1e60dfe5c1ada3388e78673112b96 
>   support/clang-tidy PRE-CREATION 
>   support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 
>   support/mesos-tidy.sh c33dfe04266ccf83ee95a3da00468611ff71aa5e 
>   support/mesos-tidy/entrypoint.sh bdaa4539cb736a15c92d55b66036df753438e283 
> 
> 
> Diff: https://reviews.apache.org/r/63649/diff/1/
> 
> 
> Testing
> -------
> 
> `support/mesos-tidy.sh`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message