mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63492: Synchronized agent resource versions via 'UpdateSlaveMessage'.
Date Tue, 07 Nov 2017 22:03:00 GMT


> On Nov. 7, 2017, 7:08 p.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 6648-6651 (patched)
> > <https://reviews.apache.org/r/63492/diff/5/?file=1883699#file1883699line6648>
> >
> >     I am a little hesitate about this. Resource estimator can change quite frequently,
and any change will invalidate some operations for the regular agent default resources.
> >     
> >     Currently, we don't allow any operation to operate on oversubscribed resources
yet. So I am learning towards not changing the clock here with a big TODO saying that we might
want to do that in the future if we allow operation for oversubscribed resources.
> >     
> >     Alternatively, we can keep separate clock for oversubscribed resources. We don't
have to do it for now.

Good point. I removed the update for now and added a `TODO`.


> On Nov. 7, 2017, 7:08 p.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 6719-6722 (patched)
> > <https://reviews.apache.org/r/63492/diff/5/?file=1883699#file1883699line6719>
> >
> >     can this simply be:
> >     
> >     `resourceVersions[resourcProviderId] = resourceVersionUuid;`

No, this is not possible as `operator[]` would need to be able to default-construct an entry;
`UUID` cannot be default-constructed.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63492/#review190251
-----------------------------------------------------------


On Nov. 7, 2017, 11 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63492/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 11 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit introduces agent resource versions to the master and
> agents. Agents are responsible for maintaining their resource
> versions. The resource versions are synchronized with the master via
> 'UpdateSlaveMessage'.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 95f57da820db676874302f1c3138a76c22a88593 
>   src/common/protobuf_utils.cpp 7a4b87becbe73f0fa97ebceee6b71ede8dce90dd 
>   src/master/master.hpp 0c1253aa1a88d113d42ce362d6992ad84217728c 
>   src/master/master.cpp ee212c1a21b432d3aa8e90d748d12cb0a754d57c 
>   src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
>   src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 
> 
> 
> Diff: https://reviews.apache.org/r/63492/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`, additional testing as part of https://reviews.apache.org/r/63496/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message