mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.
Date Tue, 07 Nov 2017 20:18:16 GMT


> On Nov. 2, 2017, 6:48 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto
> > Lines 512-516 (patched)
> > <https://reviews.apache.org/r/63434/diff/1/?file=1873100#file1873100line512>
> >
> >     When I see this enum, I have several questions, for example, "how this fits
into overall IPv6 story?", "shall this enum be global?", "what about `CheckInfo` message?".
Since we are going to deprecate `HealchCheck` at some point, I'm fine with adding an ad-hoc
solution here, but I would like to have a note here about what our long-term plan is (and
that provides some sorts of answers to the questions above).
> 
> Vinod Kone wrote:
>     Yea, one option is to directly use "NetworkInfo::Protocol" instead of re-declaring
it here.

I like that option, since it will be tied to `NetworkInfo` which will encapsulate our support
for IPv4 and IPv6.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review189946
-----------------------------------------------------------


On Nov. 3, 2017, 12:38 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2017, 12:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8050
>     https://issues.apache.org/jira/browse/MESOS-8050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added IPv6 capabilities for TCP and HTTP healthchecks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b 
>   include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b 
> 
> 
> Diff: https://reviews.apache.org/r/63434/diff/2/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message