mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.
Date Tue, 07 Nov 2017 18:47:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63642/
-----------------------------------------------------------

Review request for mesos, James DeFelice and Jiang Yan Xu.


Bugs: MESOS-8169
    https://issues.apache.org/jira/browse/MESOS-8169


Repository: mesos


Description
-------

Added a test to ensure that the ReregisterSlaveMessage validation
correctly allows duplicate ExecutorIDs as long as they are scoped
to different frameworks.


Diffs
-----

  src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61 
  src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
  src/python/cli_new/pip-requirements.txt ac040eec3d4d2eaa5dd7b431c2f590d8ae323258 
  src/tests/api_tests.cpp d3e812a2a6302035634d14995939aafb216970df 
  src/tests/containerizer/cgroups_isolator_tests.cpp aad3f53c87af5e87f1b85b746d16d483ca632f83

  src/tests/containerizer/cni_isolator_tests.cpp a6b660de63f767ff0ddc34791540de1427206e92

  src/tests/containerizer/runtime_isolator_tests.cpp 089605d9b0708cb35c171bad2c141c70336c07bd

  src/tests/master_validation_tests.cpp be8c8920fdd6eb72fc77247844a731070db5fa1c 


Diff: https://reviews.apache.org/r/63642/diff/1/


Testing
-------

make check (Fedora 26) with PR #248 applied.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message