mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.
Date Tue, 07 Nov 2017 18:08:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63492/#review190251
-----------------------------------------------------------




src/master/master.cpp
Lines 6931-6932 (patched)
<https://reviews.apache.org/r/63492/#comment267553>

    I'd move this to protobuf_utils `protobuf::parseResourceVersions`



src/master/master.cpp
Lines 7037 (patched)
<https://reviews.apache.org/r/63492/#comment267555>

    let's use version uuid consistently, and avoid the word `clock`



src/slave/slave.cpp
Lines 1188-1207 (patched)
<https://reviews.apache.org/r/63492/#comment267552>

    I'd move this helper to `src/common/protobuf_utils.hpp|cpp` and call it `createResourceVersions`



src/slave/slave.cpp
Line 1376 (original), 1404 (patched)
<https://reviews.apache.org/r/63492/#comment267645>

    Not yours, but can you kill one line here?



src/slave/slave.cpp
Lines 6648-6651 (patched)
<https://reviews.apache.org/r/63492/#comment267672>

    I am a little hesitate about this. Resource estimator can change quite frequently, and
any change will invalidate some operations for the regular agent default resources.
    
    Currently, we don't allow any operation to operate on oversubscribed resources yet. So
I am learning towards not changing the clock here with a big TODO saying that we might want
to do that in the future if we allow operation for oversubscribed resources.
    
    Alternatively, we can keep separate clock for oversubscribed resources. We don't have
to do it for now.



src/slave/slave.cpp
Lines 6719-6722 (patched)
<https://reviews.apache.org/r/63492/#comment267673>

    can this simply be:
    
    `resourceVersions[resourcProviderId] = resourceVersionUuid;`


- Jie Yu


On Nov. 7, 2017, 12:25 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63492/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 12:25 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit introduces agent clocks to the master and agents. Agents
> are responsible for maintaining their clock. The clocks are
> synchronized with the master via 'UpdateSlaveMessage'.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp afcc2e46882e4c610e9047ab3db7b6f100d47e17 
>   src/master/master.cpp 49bc50ead75adba82a7d8de23a87b06ccd269c48 
>   src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
>   src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a 
> 
> 
> Diff: https://reviews.apache.org/r/63492/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`, additional testing as part of https://reviews.apache.org/r/63496/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message