mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63615: Passed scheduler as a shared pointer into the callback.
Date Tue, 07 Nov 2017 16:16:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63615/#review190331
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63611, 63612, 63613, 63614, 63615]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 7, 2017, 12:58 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63615/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 12:58 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-8096
>     https://issues.apache.org/jira/browse/MESOS-8096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To ensure the lifetime of the scheduler is longer than the lifetime
> of the scheduler library driver, pass scheduler as a shared_ptr.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 
> 
> 
> Diff: https://reviews.apache.org/r/63615/diff/1/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.11.6 with Apple LLVM version 8.0.0 (clang-800.0.42.1)
> make check on various linux distributions
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message