mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 63605: Support moving in data during ProcessBase::send.
Date Tue, 07 Nov 2017 15:29:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63605/#review190318
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Hindman


On Nov. 7, 2017, 3:40 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63605/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 3:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows callers that can move in data to avoid an extra copy.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp 2e246205020c3c5b8c2eb5187a8eb3643d1e6d4d

>   3rdparty/libprocess/include/process/process.hpp dc3375ce62556322eb2bc60ade61f313ade123b8

>   3rdparty/libprocess/src/process.cpp 71ae7129ffbd0e22eda2863b17bbcf588298c37b 
>   3rdparty/libprocess/src/tests/benchmarks.cpp e6c77d565d5acf72b475a085e9504679253b4b97

>   3rdparty/libprocess/src/tests/process_tests.cpp 952c92c033e2363cff0c2c68610d3820b97d177e

> 
> 
> Diff: https://reviews.apache.org/r/63605/diff/1/
> 
> 
> Testing
> -------
> 
> Ran benchmarks before and after per benh's request, no difference:
> https://docs.google.com/spreadsheets/d/1I6iUziBwouQSn2veoj-xVpq7B9n6zdO9zPimi1IlJZ4/edit?usp=sharing
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message