mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63620: Updated offer operation handling to set resource versions.
Date Tue, 07 Nov 2017 15:10:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63620/#review190304
-----------------------------------------------------------




src/master/master.cpp
Lines 5212 (patched)
<https://reviews.apache.org/r/63620/#comment267594>

    nit: Do we require the `Some` here? I would have guessed that this would implicitly construct
some provider id since `Option`'s constructor is implicit.



src/master/master.cpp
Lines 9982 (patched)
<https://reviews.apache.org/r/63620/#comment267596>

    nit: `Some` is not needed here.



src/master/master.cpp
Lines 9987-9995 (patched)
<https://reviews.apache.org/r/63620/#comment267597>

    Since we `apply` above, we here need to instead have a hard `CHECK_SOME(uuid)`, rollback,
or apply later.


- Benjamin Bannier


On Nov. 7, 2017, 3:18 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63620/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 3:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Resource version UUIDs are used to establish a relationship between
> operation and the resource they are operating on. For each agent the
> master keeps track of its resource version and the resource version of
> the agents' resource providers. As resource versions are required in a
> 'ApplyOfferOperationMessage', the master has to find the resource
> version that's matching the resources an operation should apply to and
> set it accordingly.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ee212c1a21b432d3aa8e90d748d12cb0a754d57c 
> 
> 
> Diff: https://reviews.apache.org/r/63620/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message