mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 63613: Refactored executor test driver to avoid using uninitialized object.
Date Tue, 07 Nov 2017 12:58:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63613/
-----------------------------------------------------------

Review request for mesos, Michael Park and Vinod Kone.


Bugs: MESOS-8096
    https://issues.apache.org/jira/browse/MESOS-8096


Repository: mesos


Description
-------

The shared pointer to MockHTTPExecutor is initialized after the library,
while the library may start using it right after its initialization via
the `events` callback. This change removes the shared pointer altogether
and hence prevents possible segfaults.


Diffs
-----

  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 


Diff: https://reviews.apache.org/r/63613/diff/1/


Testing
-------

See https://reviews.apache.org/r/63615/


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message