mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Review Request 63584: Added agent ID to offer operation protobuf helper.
Date Mon, 06 Nov 2017 14:50:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63584/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jie Yu.


Repository: mesos


Description
-------

The current code expects an agent ID to be set for every instance of
'OfferOperation'. The absence of an agent ID would indicate an operation
meant for an external resource provider which isn't supported yet.


Diffs
-----

  src/common/protobuf_utils.hpp da0a84eb828e2fb064ba466d9e525cd3a85fc43a 
  src/common/protobuf_utils.cpp 4ce7021b01b9fb52ae1a8d95aa686c5b79164d67 
  src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 


Diff: https://reviews.apache.org/r/63584/diff/1/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message