mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 63494: Removed unused declaration.
Date Mon, 06 Nov 2017 10:57:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63494/#review190137
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On Nov. 2, 2017, 1:57 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63494/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 1:57 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The declaration of this operator was not needed here. It was also
> done in a surprising namespace as the 'Task' equality operator lives
> in the 'mesos' namespace while this declaration was in
> 'mesos::internal'.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.hpp 59e670532c8eb1ab1ec6cb063ace03481cd6a33d 
> 
> 
> Diff: https://reviews.apache.org/r/63494/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`, additional testing as part of https://reviews.apache.org/r/63496/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message