mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63538: Moved expectation for scheduler subscription events in some tests.
Date Mon, 06 Nov 2017 09:47:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63538/#review190133
-----------------------------------------------------------




src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 502-505 (original), 502-505 (patched)
<https://reviews.apache.org/r/63538/#comment267384>

    Since we do not AWAIT for `connected`, no need to declare and set it anymore. Here and
below.


- Alexander Rukletsov


On Nov. 3, 2017, 2:32 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63538/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2017, 2:32 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8093
>     https://issues.apache.org/jira/browse/MESOS-8093
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expectation for events `subscribed` is now before
> we await a `connected` event that will also trigger
> a subscription so that we do not miss the event.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp ee1e5e67b9eacb5909964b2951f659d1bd2233e5

>   src/tests/containerizer/cni_isolator_tests.cpp 0d68dd634771c016553313d67ddb33504d1a13c2

>   src/tests/containerizer/runtime_isolator_tests.cpp 81c0d825c689b3d00cbc21c7567c8c0c8836bf75

> 
> 
> Diff: https://reviews.apache.org/r/63538/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> sudo ./mesos-tests.sh --gtest_filter="CgroupsIsolatorTest.ROOT_CGROUPS_LimitSwap" --gtest_break_on_failure
--gtest_repeat=100
> sudo ./mesos-tests.sh --gtest_filter="DockerRuntimeIsolatorTest.ROOT_INTERNET_CURL_NestedSimpleCommand"
--gtest_break_on_failure --gtest_repeat=100
> ```
> And `make check`.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message