mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 63556: Added a test to check volume publish before running tasks.
Date Sat, 04 Nov 2017 01:57:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63556/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht.


Bugs: MESOS-7550
    https://issues.apache.org/jira/browse/MESOS-7550


Repository: mesos


Description
-------

All volumes from a storage local resource providers that are currently
used and going to be used should be published before launching a new
container. This unit test launches two tasks and checks that the publish
call prior to the second task launch includes all resources.

NOTE: Currently the test sandbox cannot be cleaned up due to
`fs::unmountAll()` failures. Suspecting that it's because of shared mount
propagation.


Diffs
-----

  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/tests/mock_slave.hpp 57189cee20511d145ae6b47a4dc2c66a14638dad 
  src/tests/mock_slave.cpp db24f9e5b71f558d2f811f0da8a9cc9c7c2dd341 
  src/tests/resource_provider/storage_local_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63556/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message