mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63023: Added a test CSI plugin.
Date Sat, 04 Nov 2017 01:09:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63023/
-----------------------------------------------------------

(Updated Nov. 4, 2017, 1:09 a.m.)


Review request for mesos, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
-------

Made `NodePublishVolume` and `NodeUnpublishVolume` idempotent. It uses the `mountpoint` command
to check if the mount point is in the mount table first.


Summary (updated)
-----------------

Added a test CSI plugin.


Bugs: MESOS-8102
    https://issues.apache.org/jira/browse/MESOS-8102


Repository: mesos


Description
-------

The test CSI plugin would just create subdirectories under its working
directories to mimic the behavior of creating volumes, then bind-mount
those volumes to mimic publish.


Diffs (updated)
-----

  src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
  src/examples/test_csi_plugin.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63023/diff/4/

Changes: https://reviews.apache.org/r/63023/diff/3-4/


Testing (updated)
-------

make tests


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message