mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 63058: Changed failure response of LAUNCH containers API.
Date Thu, 02 Nov 2017 16:01:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63058/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 9:01 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Rebase and propagate fixes from prior review.


Bugs: MESOS-7305
    https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
-------

By default, the HTTP handlers in libprocess will translate failures
(of returned Futures) into '500 Internal Server Error'.  This commit
only changes the `LAUNCH_NESTED_CONTAINER` and `LAUNCH_CONTAINER` APIs
to return '400 Bad Request' instead when the container launch fails,
as it is more likely for the failure to be a user-input error.


Diffs (updated)
-----

  src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b 
  src/tests/agent_container_api_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63058/diff/2/

Changes: https://reviews.apache.org/r/63058/diff/1-2/


Testing (updated)
-------

make check

On... 
OSX and Ubuntu 16


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message