mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 63057: Moved and refactored some nested container tests.
Date Thu, 02 Nov 2017 16:00:59 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 2, 2017, 9 a.m.)

Review request for mesos, Gilbert Song and Jie Yu.


Rebase and propagate fixes from prior review.

Bugs: MESOS-7305

Repository: mesos


This moves tests for the Nested container API found in `api_tests.cpp`
into `agent_container_api_tests.cpp` and refactors the moved tests to:
  * Exercise the MesosContainerizer, rather than mocks.
  * Parameterize tests to use the Standalone container API or Nested
    container API.
  * Parameterize tests to exercise different isolator combinations.

Additionally, the  `NestedContainerWaitNotFound` and
`NestedContainerKillNotFound` tests are now combined into

>From the `nested_mesos_containerizer_tests.cpp`, the `WaitAfterDestroy`
and `LaunchNestedThreeLevels` were deleted as the same codepaths are now
covered by `NestedContainerLaunch` and `TwoLevelNestedContainerLaunch`

Diffs (updated)

  src/tests/agent_container_api_tests.cpp PRE-CREATION 
  src/tests/api_tests.cpp b3efac942f538bcf2594a397d54042028a7aa7a5 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp fbd2887800ccfd64c8628c5d6fd77a511c8f91d5



Testing (updated)

make check

OSX and Ubuntu 16


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message