mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 63056: Parameterized test for nested container launch.
Date Thu, 02 Nov 2017 16:00:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63056/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 9 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Fixed a few issues:

* Test parameterization needs to specify the launcher along with isolators.
* Was missing a default command value for the normal nested container case.
* Reaping to speed up WaitContainer calls was racy, and thus removed.
* The FrameworkInfo for normal parent containers needed to enable checkpointing.


Bugs: MESOS-7305
    https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
-------

This introduces a new test class that is parameterized based
on the type of API used to launch (1) the parent container,
(2) the nested container, and (3) the content type (like all
other API tests).  The test is also parameterized based
on the enabled set of isolators.

Because this change overlaps with existing nested container
API tests, those test(s) will be removed.


Diffs (updated)
-----

  src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
  src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
  src/tests/agent_container_api_tests.cpp PRE-CREATION 
  src/tests/api_tests.cpp b3efac942f538bcf2594a397d54042028a7aa7a5 


Diff: https://reviews.apache.org/r/63056/diff/2/

Changes: https://reviews.apache.org/r/63056/diff/1-2/


Testing (updated)
-------

make check

On... 
OSX and Ubuntu 16


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message