mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60890: Defined API for launching standalone containers.
Date Thu, 02 Nov 2017 15:56:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60890/#review189922
-----------------------------------------------------------




include/mesos/agent/agent.proto
Lines 253-255 (patched)
<https://reviews.apache.org/r/60890/#comment267147>

    Leaving this up for discussion:
    
    The existing call (`RemoveNestedContainer`) either returns 200 or 500, so for backwards
compatibility, `RemoveContainer` does the same.
    
    On the other hand, returning a 404 may be somewhat difficult as `Containerizer::remove`
returns a `Future<Nothing>`.  Other methods like `::launch`, `::wait`, or `::kill` all
a magic value if the container doesn't exist.


- Joseph Wu


On Nov. 2, 2017, 8:50 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60890/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 8:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Launching a standalone container is very similar to launching a
> nested container, except that the caller must specify some Resources.
> As such, this patch deprecates some nested container APIs
> and replaces them with more generically named APIs.
> 
> This applies to the Launch, Wait, Kill, and Remove
> (nested) container APIs.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 4df3dcef4bd1d42cb8b4955e290bd38038355e46 
>   include/mesos/v1/agent/agent.proto e99d23d55a0951f2ed728360e103d83ea5a1ad7f 
> 
> 
> Diff: https://reviews.apache.org/r/60890/diff/5/
> 
> 
> Testing
> -------
> 
> make
> 
> See later patches in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message