mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60890: Defined API for launching standalone containers.
Date Thu, 02 Nov 2017 15:50:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60890/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 8:50 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Added HTTP response codes to the comments.  Also copy-pasted a missing comment from the unversioned
proto of WaitNestedContainer to the versioned proto.


Bugs: MESOS-7305
    https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
-------

Launching a standalone container is very similar to launching a
nested container, except that the caller must specify some Resources.
As such, this patch deprecates some nested container APIs
and replaces them with more generically named APIs.

This applies to the Launch, Wait, Kill, and Remove
(nested) container APIs.


Diffs (updated)
-----

  include/mesos/agent/agent.proto 4df3dcef4bd1d42cb8b4955e290bd38038355e46 
  include/mesos/v1/agent/agent.proto e99d23d55a0951f2ed728360e103d83ea5a1ad7f 


Diff: https://reviews.apache.org/r/60890/diff/5/

Changes: https://reviews.apache.org/r/60890/diff/4-5/


Testing
-------

make

See later patches in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message