mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60889: Added basic tests for launching standalone containers.
Date Thu, 02 Nov 2017 15:45:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60889/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 8:45 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Rebase and specify isolators in the test.


Bugs: MESOS-7305
    https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
-------

Within the containerizer, standalone containers are treated like
any other container (such as those with executors/tasks), so the
MesosContainerizerTests focus on the difference in arguments passed
for standalone containers.


Diffs (updated)
-----

  src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee

  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 


Diff: https://reviews.apache.org/r/60889/diff/3/

Changes: https://reviews.apache.org/r/60889/diff/2-3/


Testing
-------

make check

NOTE: This test is rather basic because there must be an API in order
to launch standalone containers via the agent (to test recovery of said containers during
agent recovery).  The API will be added in subsequent patches.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message