mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63499: Fixed the unit test that broke Windows build.
Date Thu, 02 Nov 2017 11:42:02 GMT


> On Nov. 2, 2017, 11:23 a.m., Alexander Rukletsov wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1413-1416 (original), 1413-1419 (patched)
> > <https://reviews.apache.org/r/63499/diff/1/?file=1878739#file1878739line1413>
> >
> >     Pease use `TEST_P_TEMP_DISABLED_ON_WINDOWS` instead

Qian pointed that it is a build failure, hence my comment does not make sense. Dropping.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189900
-----------------------------------------------------------


On Nov. 2, 2017, 8:27 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 8:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> -------
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message