mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.
Date Thu, 02 Nov 2017 07:45:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 12:45 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Took the `3rdparty/README.md` out.


Repository: mesos


Description
-------

Our upstreamed PR to the `concurrentqueue` project was merged,
(https://github.com/cameron314/concurrentqueue/commit/420509b)
which fixes the Clang / libstdc++ configuration. Since there are
a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
we bundle the latest SHA on `master` here.


Diffs (updated)
-----

  3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
  3rdparty/concurrentqueue-1.0.0-beta.tar.gz 1bf4a88362e7d60cd22474f20fff62f788539308 
  3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
  3rdparty/concurrentqueue.md PRE-CREATION 
  3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 


Diff: https://reviews.apache.org/r/63472/diff/2/

Changes: https://reviews.apache.org/r/63472/diff/1-2/


Testing
-------

With Clang-3.9.0
```bash
CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl --enable-optimize --enable-lock-free-run-queue
--enable-lock-free-event-queue --disable-java --disable-python
make distcheck
```
```bash
CC=clang CXX=clang++ cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_LIBEVENT=ON
-DENABLE_SSL=ON -DENABLE_LOCK_FREE_RUN_QUEUE=ON ..
cmake --build --target tests
ctest -V
```


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message