mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".
Date Wed, 01 Nov 2017 22:00:50 GMT


> On Nov. 1, 2017, 2:58 p.m., Andrew Schwartzmeyer wrote:
> > Emoji test: ????????
> 
> Andrew Schwartzmeyer wrote:
>     :no_entry_sign: :double_vertical_bar: :heavy_check_mark:
> 
> Andrew Schwartzmeyer wrote:
>     ????
> 
> Andrew Schwartzmeyer wrote:
>     ??
> 
> Andrew Schwartzmeyer wrote:
>     ??

Testing: ???? ?? ??


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63476/#review189842
-----------------------------------------------------------


On Nov. 1, 2017, 2:04 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63476/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 2:04 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Vinod Kone.
> 
> 
> Bugs: MESOS-8157
>     https://issues.apache.org/jira/browse/MESOS-8157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This reverts commit 815263ead42f64fd0ff320614cfada30b2e8f899.
> 
> The commit being reverted introduced a build break on Windows.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
>   src/tests/kill_policy_test_helper.cpp 28768a3fc02e3e6b2a0f531e6b6b2865aab51f3d 
> 
> 
> Diff: https://reviews.apache.org/r/63476/diff/1/
> 
> 
> Testing
> -------
> 
> Successfully built on Windows after failing to build before the revert.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message