mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63414: Added a helper to get the resoruce provider ID from an offer operation.
Date Wed, 01 Nov 2017 14:29:39 GMT


> On Oct. 30, 2017, 3:44 p.m., Benjamin Bannier wrote:
> > src/common/resources_utils.cpp
> > Lines 104-121 (patched)
> > <https://reviews.apache.org/r/63414/diff/1/?file=1872669#file1872669line104>
> >
> >     It would be great if we could explicitly `break` for any case not containing
an explicit `return`.

Yeah, it's a bug. I'll add some tests.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63414/#review189597
-----------------------------------------------------------


On Oct. 30, 2017, 3:33 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63414/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 3:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-7235
>     https://issues.apache.org/jira/browse/MESOS-7235
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a helper to get the resoruce provider ID from an offer operation.
> 
> 
> Diffs
> -----
> 
>   src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e 
>   src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c 
> 
> 
> Diff: https://reviews.apache.org/r/63414/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message