mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63453: Patched concurrentqueue to check for libstdc++ instead of GCC.
Date Wed, 01 Nov 2017 07:55:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63453/#review189787
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63453]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 31, 2017, 10:47 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63453/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2017, 10:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upstream PR available here: https://github.com/cameron314/concurrentqueue/pull/97
> 
> 
> Diffs
> -----
> 
>   3rdparty/concurrentqueue-1.0.0-beta.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63453/diff/1/
> 
> 
> Testing
> -------
> 
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl --enable-optimize --enable-lock-free-run-queue
--enable-lock-free-event-queue --disable-java --disable-python
> make check
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message