From reviews-return-67981-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Oct 31 17:12:05 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E2FB010193 for ; Tue, 31 Oct 2017 17:12:03 +0000 (UTC) Received: (qmail 33364 invoked by uid 500); 31 Oct 2017 17:12:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 33328 invoked by uid 500); 31 Oct 2017 17:12:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33313 invoked by uid 99); 31 Oct 2017 17:12:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Oct 2017 17:12:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BCC901A090D; Tue, 31 Oct 2017 17:12:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 1eiI6NlF1pZ3; Tue, 31 Oct 2017 17:12:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 124A65FAEA; Tue, 31 Oct 2017 17:12:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 60803E041C; Tue, 31 Oct 2017 17:11:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6B3E6C40151; Tue, 31 Oct 2017 17:11:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3062422817063594651==" MIME-Version: 1.0 Subject: Re: Review Request 63331: Added documentation for the `network/ports` isolator. From: Mesos Reviewbot To: Jie Yu , Qian Zhang Cc: Mesos Reviewbot , James Peach , mesos Date: Tue, 31 Oct 2017 17:11:57 -0000 Message-ID: <20171031171157.27699.79318@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63331/ X-Sender: Mesos Reviewbot References: <20171031165719.27699.72182@reviews-vm2.apache.org> In-Reply-To: <20171031165719.27699.72182@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: docs/isolators/network-ports.md Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============3062422817063594651== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/#review189735 ----------------------------------------------------------- Patch looks great! Reviews applied: [63331] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 31, 2017, 4:57 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63331/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2017, 4:57 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added documentation for the `network/ports` isolator to the Mesos > containerizer documentation. Updated the agent flags documentation with > the new isolator flags. Added changelog information to note the new > isolator, the new agent flags and new fields in the TaskStatus message. > > > Diffs > ----- > > docs/configuration/agent.md 5c1b469f28d4a7af0aebad5da65a00dd0e6c2a6c > docs/isolators/network-ports.md PRE-CREATION > docs/mesos-containerizer.md 9cb071273a5ce42784457ea01b363911fdb7773d > docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 > > > Diff: https://reviews.apache.org/r/63331/diff/2/ > > > Testing > ------- > > Manually checked rendered website. > > > Thanks, > > James Peach > > --===============3062422817063594651==--