From reviews-return-67813-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Oct 27 22:07:51 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5C1110E61 for ; Fri, 27 Oct 2017 22:07:51 +0000 (UTC) Received: (qmail 30119 invoked by uid 500); 27 Oct 2017 22:07:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 30085 invoked by uid 500); 27 Oct 2017 22:07:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 30073 invoked by uid 99); 27 Oct 2017 22:07:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Oct 2017 22:07:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BC7FD1A0CE8; Fri, 27 Oct 2017 22:07:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 6owNGSZCzyiM; Fri, 27 Oct 2017 22:07:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BB3265F5B8; Fri, 27 Oct 2017 22:07:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0E704E0373; Fri, 27 Oct 2017 22:07:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 9CD8DC40733; Fri, 27 Oct 2017 22:07:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6321705794174189116==" MIME-Version: 1.0 Subject: Re: Review Request 63018: Added filesystem layout for local resource providers. From: Chun-Hung Hsiao To: Jie Yu , Joseph Wu , Jan Schlicht Cc: Chun-Hung Hsiao , mesos Date: Fri, 27 Oct 2017 22:07:44 -0000 Message-ID: <20171027220744.63764.8765@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63018/ X-Sender: Chun-Hung Hsiao References: <20171020202817.61409.42551@reviews-vm2.apache.org> In-Reply-To: <20171020202817.61409.42551@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============6321705794174189116== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/ ----------------------------------------------------------- (Updated Oct. 27, 2017, 10:07 p.m.) Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Changes ------- Removed the cross-agent `resource_providers` directory. Bugs: MESOS-8097 https://issues.apache.org/jira/browse/MESOS-8097 Repository: mesos Description (updated) ------- A local resource provide can store checkpoints, whose lifecycles should be tied to the slave id, under `/meta/slaves//resource_providers/// `. Diffs (updated) ----- src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed src/resource_provider/local.hpp ebaa07d03ad77d516066ee2d4b60864be0611b5f src/resource_provider/local.cpp ad98f333c5668ca81de6e7ed3fc8f59323b151da src/resource_provider/storage/provider.hpp 6de88c2329b358fcf48bc39ddda0132170991c3c src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f src/slave/paths.hpp f000508d414daf9f943561f89c7105503a8a98b3 src/slave/paths.cpp fd546525b900cb6524fb9196d19616ef18de0f30 Diff: https://reviews.apache.org/r/63018/diff/3/ Changes: https://reviews.apache.org/r/63018/diff/2-3/ Testing ------- make Thanks, Chun-Hung Hsiao --===============6321705794174189116==--