From reviews-return-67709-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Oct 26 16:27:24 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F588102A3 for ; Thu, 26 Oct 2017 16:27:24 +0000 (UTC) Received: (qmail 57690 invoked by uid 500); 26 Oct 2017 16:27:24 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57654 invoked by uid 500); 26 Oct 2017 16:27:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57643 invoked by uid 99); 26 Oct 2017 16:27:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Oct 2017 16:27:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 59C7E1A08E3; Thu, 26 Oct 2017 16:27:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 1SE_zzUlUAlb; Thu, 26 Oct 2017 16:27:22 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 92F855FAC9; Thu, 26 Oct 2017 16:27:21 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0094CE00B3; Thu, 26 Oct 2017 16:27:21 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 16B7BC408AB; Thu, 26 Oct 2017 16:27:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5832877204344438328==" MIME-Version: 1.0 Subject: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`. From: Andrew Schwartzmeyer To: Jie Yu , John Kordich , Joseph Wu , Jeff Coffler Cc: Andrew Schwartzmeyer , mesos Date: Thu, 26 Oct 2017 16:27:17 -0000 Message-ID: <20171026162717.51092.98598@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63268/ X-Sender: Andrew Schwartzmeyer Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============5832877204344438328== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/ ----------------------------------------------------------- Review request for mesos, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu. Repository: mesos Description ------- This changes the CamelCase to snake_case per the style guide for stout. It also adds `::` to uses of `::GetLastError` where it was missing, and includes `` because it was used but missing. Diffs ----- 3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 Diff: https://reviews.apache.org/r/63268/diff/1/ Testing ------- Thanks, Andrew Schwartzmeyer --===============5832877204344438328==--